codeant-ai-for-open-source[bot] commented on code in PR #41860:
URL: https://github.com/apache/superset/pull/41860#discussion_r3575439645
##########
superset/mcp_service/chart/chart_utils.py:
##########
@@ -891,6 +893,64 @@ def map_pie_config(config: PieChartConfig) -> Dict[str,
Any]:
return form_data
+def map_histogram_config(config: "HistogramChartConfig") -> Dict[str, Any]:
+ """Map histogram config to Superset form_data (viz_type histogram_v2).
+
+ Matches the frontend Histogram buildQuery contract: a single ``column``
+ string to bin, ``groupby`` name list for series, plus bins/normalize/
+ cumulative passed straight through to the histogram post-processing
+ operator.
+ """
+ form_data: Dict[str, Any] = {
+ "viz_type": "histogram_v2",
+ "column": config.column.name,
+ "groupby": [g.name for g in (config.groupby or [])],
+ "bins": config.bins,
+ "normalize": config.normalize,
+ "cumulative": config.cumulative,
+ "row_limit": config.row_limit,
+ }
+ _add_adhoc_filters(form_data, config.filters)
+ return form_data
+
+
+# The exact strings the frontend boxplotOperator understands; the percentile
+# variant must match its PERCENTILE_REGEX: "<low>/<high> percentiles".
+_WHISKER_TYPE_TO_OPTION = {
+ "tukey": "Tukey",
Review Comment:
**Suggestion:** Add an explicit type annotation to this newly introduced
module-level mapping constant so it complies with the projectโs type-hint
requirement. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This is a newly introduced module-level constant without a type annotation,
and the stated rule requires type hints on relevant variables that can be
annotated. A dict[str, str] annotation would satisfy the rule.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=bdb7237abf9b4275b97069609654854c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=bdb7237abf9b4275b97069609654854c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/mcp_service/chart/chart_utils.py
**Line:** 917:920
**Comment:**
*Custom Rule: Add an explicit type annotation to this newly introduced
module-level mapping constant so it complies with the projectโs type-hint
requirement.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41860&comment_hash=bd0463b85fac7eb70a9745768930c4389cc427c639591687a106bb5bcd8f2e2e&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41860&comment_hash=bd0463b85fac7eb70a9745768930c4389cc427c639591687a106bb5bcd8f2e2e&reaction=dislike'>๐</a>
##########
superset/mcp_service/chart/plugins/histogram.py:
##########
@@ -0,0 +1,186 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""Histogram chart type plugin."""
+
+from __future__ import annotations
+
+from collections.abc import Mapping
+from typing import Any, ClassVar
+
+from superset.mcp_service.chart.chart_utils import (
+ _summarize_filters,
+ map_histogram_config,
+)
+from superset.mcp_service.chart.plugin import BaseChartPlugin
+from superset.mcp_service.chart.schemas import ColumnRef, HistogramChartConfig
+from superset.mcp_service.chart.validation.dataset_validator import
DatasetValidator
+from superset.mcp_service.common.error_schemas import ChartGenerationError
+
+
+class HistogramChartPlugin(BaseChartPlugin):
+ """Plugin for histogram chart type."""
+
+ chart_type = "histogram"
+ display_name = "Histogram"
+ native_viz_types: ClassVar[Mapping[str, str]] = {
+ "histogram_v2": "Histogram",
+ }
+
+ def pre_validate(
+ self,
+ config: dict[str, Any],
+ ) -> ChartGenerationError | None:
+ if "column" not in config:
+ return ChartGenerationError(
+ error_type="missing_histogram_fields",
+ message="Histogram missing required field: 'column'",
+ details=(
+ "Histograms bin the values of a single numeric column "
+ "into frequency buckets"
+ ),
+ suggestions=[
+ "Add 'column' field: {'name': 'numeric_column'}",
+ "Example: {'chart_type': 'histogram', "
+ "'column': {'name': 'trip_duration'}, 'bins': 10}",
+ ],
+ error_code="MISSING_HISTOGRAM_FIELDS",
+ )
+ return None
+
+ def extract_column_refs(self, config: Any) -> list[ColumnRef]:
+ if not isinstance(config, HistogramChartConfig):
+ return []
+ refs: list[ColumnRef] = [config.column]
+ refs.extend(config.groupby or [])
+ if config.filters:
+ for f in config.filters:
+ refs.append(ColumnRef(name=f.column))
+ return refs
+
+ def to_form_data(
+ self, config: Any, dataset_id: int | str | None = None
+ ) -> dict[str, Any]:
+ return map_histogram_config(config)
+
+ def generate_name(self, config: Any, dataset_name: str | None = None) ->
str:
+ what = f"Distribution of {config.column.label or config.column.name}"
+ if config.groupby:
+ what += " by " + ", ".join(g.label or g.name for g in
config.groupby)
+ context = _summarize_filters(config.filters)
+ return self._with_context(what, context)
+
+ def post_map_validate(
+ self,
+ config: Any,
+ form_data: dict[str, Any],
+ dataset_id: int | str | None = None,
+ ) -> ChartGenerationError | None:
+ """Require a numeric binned column, mirroring the Explore UI.
+
+ The frontend control panel restricts the histogram column to
+ ``GenericDataType.Numeric``; without this check an LLM picking a
+ text column passes pre-validation and only fails at query time.
+ """
+ if not isinstance(config, HistogramChartConfig) or dataset_id is None:
+ return None
+
+ dataset_context = DatasetValidator._get_dataset_context(dataset_id)
+ if dataset_context is None:
+ return None
+
+ col_info = next(
+ (
+ col
+ for col in dataset_context.available_columns
+ if col["name"].lower() == (config.column.name or "").lower()
+ ),
+ None,
+ )
+ if col_info is None:
+ # Column existence is validated separately; don't double-report.
+ return None
+
+ numeric_types = ["INTEGER", "FLOAT", "DOUBLE", "DECIMAL", "NUMERIC"]
Review Comment:
**Suggestion:** Add a concrete local variable type annotation for this
collection of SQL type names. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This local variable is introduced without a type annotation even though its
type is obvious and stable, so it violates the Python type-hint requirement.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=3cc57a9783f142f09936ed0f49cfb868&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=3cc57a9783f142f09936ed0f49cfb868&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/mcp_service/chart/plugins/histogram.py
**Line:** 118:118
**Comment:**
*Custom Rule: Add a concrete local variable type annotation for this
collection of SQL type names.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41860&comment_hash=f8def7048408ed1b8f6131536f953c82fc970f0060f8eca4068c0cc08ffad61e&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41860&comment_hash=f8def7048408ed1b8f6131536f953c82fc970f0060f8eca4068c0cc08ffad61e&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
