codeant-ai-for-open-source[bot] commented on code in PR #41974:
URL: https://github.com/apache/superset/pull/41974#discussion_r3566354920
##########
superset/commands/importers/v1/utils.py:
##########
@@ -149,6 +149,7 @@ def load_configs(
prefix = file_name.split("/")[0]
schema = schemas.get(f"{prefix}/")
if schema:
+ config = None
Review Comment:
**Suggestion:** Add an explicit type annotation for this newly introduced
local variable so its optional shape is clear during validation and exception
handling. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This new local variable is later used as a dictionary-like YAML config but
is initialized as None without any type annotation. The custom rule requires
type hints on relevant variables that can be annotated, so this is a real
violation.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=9bdbf2f88b534e499a5fb136a5871afd&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=9bdbf2f88b534e499a5fb136a5871afd&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/importers/v1/utils.py
**Line:** 152:152
**Comment:**
*Custom Rule: Add an explicit type annotation for this newly introduced
local variable so its optional shape is clear during validation and exception
handling.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41974&comment_hash=63b4d0ccde93ed1e7c034bf120322050f36e502a45fad34baa779f8d691a46fd&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41974&comment_hash=63b4d0ccde93ed1e7c034bf120322050f36e502a45fad34baa779f8d691a46fd&reaction=dislike'>๐</a>
##########
tests/unit_tests/commands/importers/v1/utils_test.py:
##########
@@ -117,3 +124,62 @@ def test_warning_count_excludes_preexisting_nulls(self) ->
None:
call_args = mock_logger.warning.call_args[0]
assert call_args[1] == 2 # 2 out-of-bounds, 1 pre-existing null
+
+
+class TestLoadConfigs:
+ def test_load_configs_caught_exception_and_log_redacted_configs(self) ->
None:
+ logging.basicConfig(level=logging.DEBUG)
+ from superset.commands.importers.v1.utils import (
+ load_configs,
+ )
+
+ with (
+ patch("superset.db") as mock_db,
+ patch("yaml.safe_load") as mock_yaml_safe_load,
+ patch("superset.commands.importers.v1.utils.logger") as
mock_logger,
+ ):
+ mock_yaml_safe_load.return_value = {
+ "masked_encrypted_extra": json.dumps(
+ {"oauth2_client_info": {"secret": "MASKED"}}
+ ),
+ "ssh_tunnel": {},
+ }
+ mock_db.session.query.return_value = {"uuid-1":
"SECRET_TO_BE_SEEN"}
+
+ class RaiseValidationSchema(Schema):
+ def load(self, value):
+ raise ValidationError("Exception when validating config")
Review Comment:
**Suggestion:** Add explicit type annotations to the inner schema `load`
method parameters and return type so the new method is fully typed.
[custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The new inner `RaiseValidationSchema.load` method omits type hints on both
the `value` parameter and the return type, which matches the Python type-hint
rule for modified code.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=939df68989bb438e99da62922ab82afb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=939df68989bb438e99da62922ab82afb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/commands/importers/v1/utils_test.py
**Line:** 149:151
**Comment:**
*Custom Rule: Add explicit type annotations to the inner schema `load`
method parameters and return type so the new method is fully typed.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41974&comment_hash=efc08f28594b6cfb4997a9a8b0028993027afd6a5c1f45a803f0a11f30fb04f0&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41974&comment_hash=efc08f28594b6cfb4997a9a8b0028993027afd6a5c1f45a803f0a11f30fb04f0&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
