hainenber commented on code in PR #41974:
URL: https://github.com/apache/superset/pull/41974#discussion_r3566404068
##########
superset/commands/importers/v1/utils.py:
##########
@@ -230,7 +231,21 @@
prefix,
exc.messages,
)
- logger.debug("Config content that failed validation: %s",
config)
+ # Mask sensitive data before logging out for debug
+ if config:
+ redacted_config = json.redact_sensitive(
+ config,
+ {
+ "$.password",
+ "$.ssh_tunnel.password",
+ "$.ssh_tunnel.private_key",
+ "$.ssh_tunnel.private_key_password",
+ "$.masked_encrypted_extra",
+ },
+ )
+ logger.debug(
+ "Config content that failed validation: %s.",
redacted_config
Review Comment:
all the known secrets have been redacted via `json.redact_sensitive`
function. Is that not enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
