rusackas commented on PR #41975: URL: https://github.com/apache/superset/pull/41975#issuecomment-4960884340
Looks like the fix only handles the `bigquery://project` URI form. `get_schema_from_engine_params`'s docstring explicitly documents that `bigquery:///project` (triple-slash) puts the project in `url.database` with no host. There's already a test (test_get_default_catalog) exercising all three URI forms, indicating users on the triple-slash style would still hit the exact bug this PR intends to fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
