Abhiiishek44 commented on PR #41975:
URL: https://github.com/apache/superset/pull/41975#issuecomment-4974021192

   I updated `_get_client()` to resolve the project from `url.host` first and 
fall back to `url.database`, covering both `bigquery://project` and 
`bigquery:///project`.
   
   I also parameterized the `_get_client()` tests to cover both URI forms and 
the no-project `bigquery://` case, which verifies that `project=None` is 
preserved when no project is specified in the URI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to