codeant-ai-for-open-source[bot] commented on code in PR #42006:
URL: https://github.com/apache/superset/pull/42006#discussion_r3573034293
##########
superset-frontend/packages/superset-ui-core/src/components/RefreshLabel/index.tsx:
##########
@@ -36,6 +36,7 @@ const RefreshLabel = ({
<Icons.SyncOutlined
iconSize="l"
role="button"
+ tabIndex={disabled ? -1 : 0}
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> When a PR is only addressing `interactive-supports-focus`, review it only
for focusability (`tabIndex`/focus reachability) and do not require Enter/Space
keyboard activation until the separate `click-events-have-key-events` change is
being reviewed.
**Applied to:**
- `**/*.tsx`
- `**/*.jsx`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
##########
superset-frontend/src/features/queries/QueryPreviewModal.tsx:
##########
@@ -148,6 +148,7 @@ function QueryPreviewModal({
<QueryViewToggle>
<TabButton
role="button"
+ tabIndex={0}
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> When reviewing `interactive-supports-focus` in TSX files, accept
`tabIndex={0}` on custom interactive elements; do not require Enter/Space key
handlers in the same change when those handlers are covered by a separate
`click-events-have-key-events` fix.
**Applied to:**
- `**/*.tsx`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
