rusackas commented on code in PR #42006:
URL: https://github.com/apache/superset/pull/42006#discussion_r3573031719
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CrossFilters/ScopingModal/ChartsScopingListPanel.tsx:
##########
@@ -142,6 +142,7 @@ export const ChartsScopingListPanel = ({
</AddButtonContainer>
<FilterTitle
role="button"
+ tabIndex={0}
Review Comment:
This is the `interactive-supports-focus` rule, which just makes the element
focusable. The Enter/Space activation is `click-events-have-key-events`, which
is the next PR in this series and adds handlers to these same elements.
tabIndex is the right fix for the rule this PR turns on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
