alok844937-design commented on issue #36325: URL: https://github.com/apache/superset/issues/36325#issuecomment-4964340082
Hi @sfirke , I can reproduce this on `master` (0.0.0dev) using the `cleaned_sales_data` example. With an Area chart, `order_date` on the x-axis (Day grain), and X Axis Label Interval = All, most labels are still skipped. The same setting works as expected on a categorical/string x-axis, so the issue seems specific to time axes. I traced this through `Timeseries/transformProps.ts`. The selected value is passed correctly to `axisLabel.interval`, but on a time axis ECharts appears to determine label placement from the generated ticks (and `minInterval`) rather than `axisLabel.interval`. Since `minInterval` is fixed to the selected time grain, the All option doesn't seem to have any effect for temporal axes. Before working on a fix, I wanted to check what the intended behavior should be. I can think of two possible approaches: Make the All option work on time axes as well by adjusting how labels/ticks are generated. Keep the current behavior, but clarify in the UI/help text that this option only applies to categorical axes. Do you have a preference for which direction would be more appropriate? I'm happy to work on it once I know the expected behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
