gkneighb commented on code in PR #41860: URL: https://github.com/apache/superset/pull/41860#discussion_r3575705511
########## superset/mcp_service/chart/plugins/box_plot.py: ########## @@ -0,0 +1,155 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file Review Comment: Declining, standing rationale: bare class-level chart_type/display_name constants and inferable locals follow BaseChartPlugin's convention shared by all in-tree plugins; mypy passes. Identical future findings will be declined the same way. ########## superset/mcp_service/chart/plugins/box_plot.py: ########## @@ -0,0 +1,155 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the Review Comment: Declining, standing rationale: bare class-level chart_type/display_name constants and inferable locals follow BaseChartPlugin's convention shared by all in-tree plugins; mypy passes. Identical future findings will be declined the same way. ########## superset/mcp_service/chart/plugins/box_plot.py: ########## @@ -0,0 +1,155 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the Review Comment: Declining, standing rationale: bare class-level chart_type/display_name constants and inferable locals follow BaseChartPlugin's convention shared by all in-tree plugins; mypy passes. Identical future findings will be declined the same way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
