codeant-ai-for-open-source[bot] commented on code in PR #41860: URL: https://github.com/apache/superset/pull/41860#discussion_r3575623310
########## tests/unit_tests/mcp_service/chart/test_histogram_boxplot_charts.py: ########## @@ -0,0 +1,371 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Tests for the histogram and box plot chart type plugins. + +Schema validation, form_data mapping (matching the frontend buildQuery +contracts for viz_type ``histogram_v2`` and ``box_plot``), and registry +integration. +""" + +import pytest +from pydantic import TypeAdapter, ValidationError + +from superset.mcp_service.chart.chart_utils import ( + map_box_plot_config, + map_histogram_config, +) +from superset.mcp_service.chart.schemas import ( + BoxPlotChartConfig, + ChartConfig, + HistogramChartConfig, +) +from superset.mcp_service.common.error_schemas import ChartGenerationError Review Comment: ✅ **Customized review instruction saved!** **Instruction:** > Do not flag Python imports as unused when they are referenced only in string type annotations; Ruff recognizes these as used in typing contexts. **Applied to:** - `**/*.py` --- 💡 *To manage or update this instruction, visit: [CodeAnt AI Settings](https://app.codeant.ai/org/settings/learnings)* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
