jayvenn21 commented on PR #37773: URL: https://github.com/apache/superset/pull/37773#issuecomment-4970693072
Thanks and good catch @rusackas. I've reproduced this locally on my machine and you’re right as hiding ResetMyPasswordView by default breaks the forced-password-change path, since that flow still needs the self-service reset form. I've updated the branch so ResetPasswordView stays hidden by default, but ResetMyPasswordView is still registered when ENABLE_FORCE_PASSWORD_CHANGE=True. also, i've added a small test covering that flag combo on the FAB question, I couldn’t find a follow-up FAB PR for a broader config flag like FAB_ADD_SECURITY_VIEWS. The only related FAB change I found was the existing AuthDB-specific reset-password registration fix, so unless we want to pause and pursue that upstream first, this is still a Superset-side workaround. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
