rusackas commented on PR #37773: URL: https://github.com/apache/superset/pull/37773#issuecomment-5039570873
Thanks for tracking down the force-password-change fix, @jayvenn21, that part looks right now: `ResetMyPasswordView` stays registered when `ENABLE_FORCE_PASSWORD_CHANGE` is on, and the test covers the flag combo. Still want to close the loop on @dpgaspar's suggestion though, whether this should be an upstream FAB flag instead of monkeypatching `appbuilder.add_view_no_menu` here. Sounds like that path wasn't pursued. Worth deciding before this lands, since CI hasn't actually run on the latest push either (still showing cancelled), so nothing's confirmed green yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
