aminghadersohi commented on code in PR #41599:
URL: https://github.com/apache/superset/pull/41599#discussion_r3581973352
##########
superset/mcp_service/chart/tool/generate_chart.py:
##########
@@ -110,30 +110,44 @@ async def generate_chart( # noqa: C901
IMPORTANT: The 'chart_type' field in the config is a DISCRIMINATOR that
determines
which chart configuration schema to use. It MUST be included and MUST
match the
- other fields in your configuration:
+ other fields in your configuration. There are exactly 7 valid chart_type
values
+ — NOT 'line', 'bar', 'mixed_timeseries', etc. Those are 'kind' values
WITHIN
+ chart_type='xy' (see below), not chart_type values themselves:
Review Comment:
Fixed in dff2aa57d2: the intro now lists only line, bar, area, and scatter
as xy kind values, while mixed_timeseries remains documented as one of the
seven valid chart_type discriminators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
