mikebridge commented on PR #42052: URL: https://github.com/apache/superset/pull/42052#issuecomment-4974431282
### Possible future follow-up: validate bounded queries have a time-filter subject This PR fixes the concrete normalization gap, but a useful defensive improvement would be to validate normalized `QueryObject` instances before SQL generation. The targeted invariant would be: - `from_dttm` or `to_dttm` is present; - no physical granularity/time column is present; and - no explicit temporal filter identifies a physical column. In that state, the supplied bounds cannot affect the generated SQL. Superset could emit a targeted warning or raise a query-validation error rather than silently executing an unbounded query. A generic check that every `QueryObject` field appears in SQL would be too noisy because some fields intentionally affect post-processing, caching, annotations, or separate subqueries. The narrower time-constraint invariant has clear semantics and would have detected this failure before ClickHouse reached `max_rows_to_read`. This is a suggested future follow-up, not additional scope or a blocker for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
