mikebridge commented on PR #42052: URL: https://github.com/apache/superset/pull/42052#issuecomment-4983396954
Potential future follow-up (not a blocker for this PR): when granularity is inferred from `main_dttm_col`, a query that also contains an explicit `TEMPORAL_RANGE` filter on that same column may generate two equivalent time predicates because the inferred path returns before the existing filter cleanup. This should not change query results, but removing only the matching same-column temporal filter could avoid redundant SQL while continuing to preserve independent filters on other datetime columns. It would also be useful for that follow-up to add coverage through the public query-context factory path—not only direct `_apply_granularity` tests—so we explicitly verify the distinction between a dashboard `time_range` and bounds derived solely from an explicit temporal filter, plus the same-column case above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
