rusackas commented on PR #41984: URL: https://github.com/apache/superset/pull/41984#issuecomment-4976722826
Thanks @aikawa-ohno, the Japanese translations here look like solid work, and clearing out the fuzzy flags and the old `# Machine-translated via backfill_po.py` comments is exactly the right direction. One thing before we can merge though: the file currently fails `msgfmt -c`. Un-fuzzying the `%(suggestion)s instead of...` plural entry left a `msgstr[0]` that's missing a couple of the plural placeholders, and there's a malformed `#,python-format` flag (missing the space) snuck in too. Easiest path is to rebase on current `master` (it's conflicting right now anyway) and run `scripts/translations/babel_update.sh`, then commit the result. That'll clean up the flag spacing and sort out the `% calculation` / `% of parent` / `% of total` entries automatically. The codeant bot comment about `msgstr[1]` doesn't apply here, so safe to ignore that one. Holler if you want a hand with the rebase! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
