bito-code-review[bot] commented on code in PR #42079:
URL: https://github.com/apache/superset/pull/42079#discussion_r3586076972
##########
superset/models/core.py:
##########
@@ -518,35 +505,7 @@ def get_sqla_engine( # pylint: disable=too-many-arguments
sqlalchemy_uri=sqlalchemy_uri,
cacheable=not prequeries,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Runtime NameError for undefined variable</b></div>
<div id="fix">
Line 506 references undefined variable `prequeries` which will raise
`NameError` at runtime. The prequery event-listener logic was removed from
`_get_sqla_engine()` and moved to `get_raw_connection()` (lines 648-659), but
the reference at line 506 was left behind. Remove the `cacheable=not
prequeries` argument.
</div>
</div>
<small><i>Code Review Run #b1c9c6</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
