rusackas commented on PR #42079: URL: https://github.com/apache/superset/pull/42079#issuecomment-5005990843
Thanks for adopting this one @alseerx. I worry though the fix might trade one bug for another. `get_sqla_engine()` no longer runs prequeries at all now, so anything that grabs an engine and calls `engine.connect()` directly still needs them and won't get them. E.g. `has_view` and `get_values_for_column` in models/helpers.py, the presto sql validator, and `get_inspector` (which is how StarRocks EXECUTE AS impersonation is applied per its own docstring). That's the same thing codeant-ai flagged on core.py, which hasn't been addressed/resolved. Prequeries need to run wherever a fresh connection comes off one of these engines, not just inside get_raw_connection(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
