codeant-ai-for-open-source[bot] commented on code in PR #42102: URL: https://github.com/apache/superset/pull/42102#discussion_r3592702582
########## superset/translations/zh_TW/LC_MESSAGES/messages.po: ########## @@ -5450,12 +5553,11 @@ msgid "Define color breakpoints for the data" msgstr "為資料定義色彩中斷點" msgid "" -"Define contour layers. Isolines represent a collection of line segments that" -" serparate the area above and below a given threshold. Isobands represent a " -"collection of polygons that fill the are containing values in a given " -"threshold range." -msgstr "" -"定義等高線圖層。等值線代表一組線段的集合，這些線段將高於和低於給定閥值的區域分隔開來。等值带代表一組多邊形的集合，用以填充包含在給定閥值範圍内的區域。" +"Define contour layers. Isolines represent a collection of line segments " +"that serparate the area above and below a given threshold. Isobands " Review Comment: **Suggestion:** The source string contains a clear typo (`serparate`), which will be shown to users in English fallback contexts and propagates to translation catalogs. Correct the misspelling to `separate` to avoid user-facing copy errors. [typo] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx ⚠️ Contour layer help text shows misspelled word. ⚠️ Translation catalogs propagate typo across supported locales. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Open the translation catalog at `superset/translations/zh_TW/LC_MESSAGES/messages.po` and locate the contour-layer help text msgid block around lines 5556–5559 (added in this PR), specifically line 5557 containing `that serparate the area above and below a given threshold. Isobands`. 2. Build and run Superset with the zh_TW locale enabled so that `messages.po` is compiled into `messages.mo` and loaded by the i18n system for UI help/tooltips (all msgid strings in this catalog are candidates for frontend use). 3. In the Explore UI, configure a deck.gl Contour or related visualization; the help text for the contour layers control is sourced from this msgid and will display the misspelled English word `serparate` if English or mixed-language help is shown. 4. Observe that the UI help text and all catalogs that reuse this msgid show the typo `serparate` instead of `separate`, causing a visible copy error and propagating the typo across multiple locales that share this source string. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=1dfbc63981824ecdbfee2c887a780a14&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=1dfbc63981824ecdbfee2c887a780a14&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/zh_TW/LC_MESSAGES/messages.po **Line:** 5557:5557 **Comment:** *Typo: The source string contains a clear typo (`serparate`), which will be shown to users in English fallback contexts and propagates to translation catalogs. Correct the misspelling to `separate` to avoid user-facing copy errors. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42102&comment_hash=833776036dee6802abdaea95f32ee102aef13e8112c57961788b68407609502e&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42102&comment_hash=833776036dee6802abdaea95f32ee102aef13e8112c57961788b68407609502e&reaction=dislike'>👎</a> ########## superset/translations/zh_TW/LC_MESSAGES/messages.po: ########## @@ -5450,12 +5553,11 @@ msgid "Define color breakpoints for the data" msgstr "為資料定義色彩中斷點" msgid "" -"Define contour layers. Isolines represent a collection of line segments that" -" serparate the area above and below a given threshold. Isobands represent a " -"collection of polygons that fill the are containing values in a given " -"threshold range." -msgstr "" -"定義等高線圖層。等值線代表一組線段的集合，這些線段將高於和低於給定閥值的區域分隔開來。等值带代表一組多邊形的集合，用以填充包含在給定閥值範圍内的區域。" +"Define contour layers. Isolines represent a collection of line segments " +"that serparate the area above and below a given threshold. Isobands " +"represent a collection of polygons that fill the are containing values in" Review Comment: **Suggestion:** The phrase `fill the are containing` has a clear typo (`are` instead of `area`), which makes the help text grammatically incorrect; fix the noun to keep chart-control descriptions accurate. [typo] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx ⚠️ Contour description contains grammatically incorrect phrase. ⚠️ Chart-control help text appears unprofessional to users. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Open `superset/translations/zh_TW/LC_MESSAGES/messages.po` and inspect the contour-layer help msgid block starting at line 5556 (`Define contour layers. Isolines represent a collection of line segments`); at line 5558 the English source text reads `represent a collection of polygons that fill the are containing values in`. 2. Build Superset with zh_TW translations so that this msgid is compiled and available to the frontend i18n layer for contour chart configuration tooltips and descriptions. 3. In the Explore UI, configure a deck.gl Contour visualization and open the help text for the contour layers control; the string from this msgid is used to explain Isobands and will surface the phrase `fill the are containing values in ...`. 4. Observe that the help text is grammatically incorrect (`are` instead of `area`), leading to unprofessional, confusing descriptive UI copy and mirrored typos in other locales that share this English msgid as their source. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=0b8d80f2567a4e38863192950e720ea8&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=0b8d80f2567a4e38863192950e720ea8&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/zh_TW/LC_MESSAGES/messages.po **Line:** 5558:5558 **Comment:** *Typo: The phrase `fill the are containing` has a clear typo (`are` instead of `area`), which makes the help text grammatically incorrect; fix the noun to keep chart-control descriptions accurate. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42102&comment_hash=e0de9c3d17d788d402f6126e91606029e1153c1790343588ee350548fcb064b0&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42102&comment_hash=e0de9c3d17d788d402f6126e91606029e1153c1790343588ee350548fcb064b0&reaction=dislike'>👎</a> ########## superset/translations/zh_TW/LC_MESSAGES/messages.po: ########## @@ -5010,14 +5112,14 @@ msgid "Data connections" msgstr "資料庫連接" msgid "" -"Data could not be deserialized from the results backend. The storage format " -"might have changed, rendering the old data stake. You need to re-run the " -"original query." +"Data could not be deserialized from the results backend. The storage " +"format might have changed, rendering the old data stake. You need to re-" Review Comment: **Suggestion:** This string has an obvious typo (`data stake`) that should be `data stale`; leaving it as-is results in incorrect user-facing error text and inconsistent catalogs across locales. [typo] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx ⚠️ Error message shows incorrect term “data stake”. ⚠️ Confuses users diagnosing backend deserialization issues. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Open `superset/translations/zh_TW/LC_MESSAGES/messages.po` and find the msgid block at lines 5115–5117 beginning with `Data could not be deserialized from the results backend. The storage`, where line 5116 reads `format might have changed, rendering the old data stake. You need to re-`. 2. Build Superset with zh_TW translations; this catalog is compiled and loaded so that backend error strings (including this msgid) can be shown in the UI for SQL Lab and chart queries when result-backend deserialization fails. 3. Trigger a cached-result deserialization failure (for example, by invalidating or changing the results backend storage format) so the error message using this msgid is raised and surfaced through the generic error-handling paths tied to the results backend. 4. In the UI, observe the error text containing the phrase `rendering the old data stake`, which is a typo for `data stale`, leading to confusing and incorrect user-facing copy and inconsistent wording across locales that reuse this English source string. ``` </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e1622618d49246749b723860a29ab984&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e1622618d49246749b723860a29ab984&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/translations/zh_TW/LC_MESSAGES/messages.po **Line:** 5116:5116 **Comment:** *Typo: This string has an obvious typo (`data stake`) that should be `data stale`; leaving it as-is results in incorrect user-facing error text and inconsistent catalogs across locales. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42102&comment_hash=ed9ba43519bb5f23775b8ca0502b978800b4588602e58684978b7857b67c17ba&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42102&comment_hash=ed9ba43519bb5f23775b8ca0502b978800b4588602e58684978b7857b67c17ba&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
