codeant-ai-for-open-source[bot] commented on code in PR #42101:
URL: https://github.com/apache/superset/pull/42101#discussion_r3592705638
##########
superset/translations/it/LC_MESSAGES/messages.po:
##########
@@ -1111,26 +1143,27 @@ msgstr ""
#, fuzzy
msgid "A JavaScript function that generates an icon configuration object"
msgstr ""
-"Una funzione JavaScript che genera un oggetto di configurazione delle icone"
+"Una funzione JavaScript che genera un oggetto di configurazione delle "
+"icone"
# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, sr,
# sr_Latn]
#, fuzzy, python-brace-format
msgid ""
"A JavaScript object that adheres to the ECharts options specification, "
-"overriding other control options with higher precedence. (i.e. { title: "
-"{ text: \"My Chart\" }, tooltip: { trigger: \"item\" } }). Details: https://";
-"echarts.apache.org/en/option.html. "
+"overriding other control options with higher precedence. (i.e. { title: {"
+" text: \"My Chart\" }, tooltip: { trigger: \"item\" } }). Details: "
+"https://echarts.apache.org/en/option.html. "
msgstr ""
"Un oggetto JavaScript conforme alla specifica delle opzioni ECharts, che "
-"sovrascrive le altre opzioni di controllo con priorità più elevata. (ad es. "
-"{ title: { text: \"My Chart\" }, tooltip: { trigger: \"item\" } }). "
+"sovrascrive le altre opzioni di controllo con priorità più elevata. (ad "
+"es. { title: { text: \"My Chart\" }, tooltip: { trigger: \"item\" } }). "
"Dettagli: https://echarts.apache.org/en/option.html. "
msgid "A comma separated list of columns that should be parsed as dates"
msgstr ""
-"Una lista separata da virgole di colonne che dovrebbero essereinterpretate "
-"come date"
+"Una lista separata da virgole di colonne che dovrebbero "
+"essereinterpretate come date"
Review Comment:
**Suggestion:** The added translation contains an obvious typo
(`essereinterpretate`) caused by a missing space, which will be shown directly
to users in the UI. Split the token into proper words so the sentence is
readable. [typo]
<details>
<summary><b>Severity Level:</b> Minor 🧹</summary>
```mdx
⚠️ Italian help text shows merged word `essereinterpretate`.
⚠️ Minor translation quality issue in date-parsing configuration.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Italian translations are loaded from
`superset/translations/it/LC_MESSAGES/messages.po`, including the entry at
lines 1163–1166
for msgid `A comma separated list of columns that should be parsed as dates`
(confirmed
via Grep).
2. The Italian msgstr for that entry at `messages.po:1165-1166` reads `"Una
lista separata
da virgole di colonne che dovrebbero "` followed by `"essereinterpretate
come date"`,
where `essereinterpretate` is a merged token missing a space.
3. The msgid is present in the global catalog
`superset/translations/messages.pot:786` and
therefore remains a translatable string that can be surfaced anywhere the
backend or
frontend uses that English key as help text or description for date-parsing
configuration.
4. When the application runs under the Italian locale and any UI (for
example, legacy
forms using the `A comma separated list of columns that should be parsed as
dates` help
text) formats this msgid via gettext, Italian users will see
`essereinterpretate` without
a space, which is an obvious typo in otherwise correct prose.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b3badcc92c3c439193481fa350feffa5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b3badcc92c3c439193481fa350feffa5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/it/LC_MESSAGES/messages.po
**Line:** 1165:1166
**Comment:**
*Typo: The added translation contains an obvious typo
(`essereinterpretate`) caused by a missing space, which will be shown directly
to users in the UI. Split the token into proper words so the sentence is
readable.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42101&comment_hash=3246304334e2114d37e616d4b1272dfa84f231e5842f59c701363d1e037bcdac&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42101&comment_hash=3246304334e2114d37e616d4b1272dfa84f231e5842f59c701363d1e037bcdac&reaction=dislike'>👎</a>
##########
superset/translations/it/LC_MESSAGES/messages.po:
##########
@@ -2495,28 +2538,30 @@ msgstr "Si è verificato un errore nel rendering della
visualizzazione: %s"
msgid "An error occurred while saving the semantic view"
msgstr ""
-"Si è verificato un errore nel caricare nel salvataggio della vista semantica"
+"Si è verificato un errore nel caricare nel salvataggio della vista "
+"semantica"
Review Comment:
**Suggestion:** This translation contradicts the source message intent: the
source says an error occurred while saving, but the Italian text says “loading
while saving,” which is inconsistent and misleading for troubleshooting. Update
the translation to describe only the save failure. [comment mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
❌ Semantic view save errors misreported as load issues.
⚠️ Troubleshooting semantic view saves becomes more confusing.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. The msgid `An error occurred while saving the semantic view` is defined
in the catalog
at `superset/translations/messages.pot:1745` and translated in Italian at
`superset/translations/it/LC_MESSAGES/messages.po:2539-2543` (verified via
Grep).
2. The Italian msgstr at `messages.po:2542-2543` is split across two lines:
`"Si è
verificato un errore nel caricare nel salvataggio della vista "` and
`"semantica"`, which
reads as “an error occurred while loading during saving the semantic view”.
3. In the semantic view editor UI,
`superset-frontend/src/features/semanticViews/SemanticViewEditModal.tsx:159-162`
calls
`addDangerToast(clientError.error || t('An error occurred while saving the
semantic
view'))` inside the save handler when a PUT to save the semantic view fails.
4. With Italian locale active, triggering a backend error while saving a
semantic view
(for example, a server-side validation failure on `SemanticViewEditModal`’s
form
submission) causes this toast to render with the mistranslated Italian text,
conflating
“loading” and “saving” and giving users misleading information about what
operation
actually failed.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=815674b2a7f6490e9c10d460774d1496&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=815674b2a7f6490e9c10d460774d1496&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/it/LC_MESSAGES/messages.po
**Line:** 2542:2543
**Comment:**
*Comment Mismatch: This translation contradicts the source message
intent: the source says an error occurred while saving, but the Italian text
says “loading while saving,” which is inconsistent and misleading for
troubleshooting. Update the translation to describe only the save failure.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42101&comment_hash=ceec9a7adcd4e4a1e0d65a28264b289b671d55264a62c608627e40728e48486a&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42101&comment_hash=ceec9a7adcd4e4a1e0d65a28264b289b671d55264a62c608627e40728e48486a&reaction=dislike'>👎</a>
##########
superset/translations/it/LC_MESSAGES/messages.po:
##########
@@ -4243,8 +4302,7 @@ msgid "Chart type requires a dataset"
msgstr "Il tipo di grafico richiede un dataset"
msgid "Chart was saved but could not be added to the selected tab."
-msgstr ""
-"IL grafico è stato salvato ma non può essere aggiunto al tab selezionato."
+msgstr "IL grafico è stato salvato ma non può essere aggiunto al tab
selezionato."
Review Comment:
**Suggestion:** The added string starts with `IL` in all caps, which is an
obvious typo in normal Italian sentence casing and will look unpolished in the
UI. Change it to `Il`. [typo]
<details>
<summary><b>Severity Level:</b> Minor 🧹</summary>
```mdx
⚠️ Italian toast starts with mis-capitalized “IL”.
⚠️ UI error message appears less polished to Italians.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. The English msgid `Chart was saved but could not be added to the selected
tab.` is
defined in `superset/translations/messages.pot:2905` and translated into
Italian at
`superset/translations/it/LC_MESSAGES/messages.po:4303-4305` (checked with
Grep).
2. The Italian msgstr at `messages.po:4305` is `IL grafico è stato salvato
ma non può
essere aggiunto al tab selezionato.`, where `IL` is fully capitalized
instead of the
normal sentence case `Il`.
3. In the Explore save flow,
`superset-frontend/src/explore/components/SaveModal.tsx:595-599` logs `Error
adding chart
to dashboard tab` and calls `addDangerToast(t('Chart was saved but could not
be added to
the selected tab.'))` when the chart save succeeds but adding it to the
chosen dashboard
tab fails.
4. With Italian locale enabled, reproducing that error condition (for
example, saving a
chart to a dashboard tab that cannot be created or attached due to a backend
error) causes
the toast to appear with the message beginning `IL grafico ...`, which looks
like a simple
capitalization mistake in Italian and slightly degrades the professionalism
of the UI.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=19c2b0d1a70a405389f9fbf3a8c6e0ab&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=19c2b0d1a70a405389f9fbf3a8c6e0ab&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/it/LC_MESSAGES/messages.po
**Line:** 4305:4305
**Comment:**
*Typo: The added string starts with `IL` in all caps, which is an
obvious typo in normal Italian sentence casing and will look unpolished in the
UI. Change it to `Il`.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42101&comment_hash=5c9e22b84f99b7464b047257276385d26412405d9bf2a4c734be760ea5aac612&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42101&comment_hash=5c9e22b84f99b7464b047257276385d26412405d9bf2a4c734be760ea5aac612&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
