rusackas commented on PR #32487: URL: https://github.com/apache/superset/pull/32487#issuecomment-4988568145
Thanks for making `SERVER_STATSD_HOST` opt-in, that addresses the exposure concern. My master-merge dropped the Chart.yaml version bump though, so `lint-test` is failing on a missing chart version bump. There are also two live bot notes on the docs snippet worth fixing: `int(os.environ.get(...))` can raise `ValueError` on a non-numeric `SERVER_STATSD_PORT`, and the gunicorn metrics link in `event-logging.mdx` 404s. Fix those three and I think we're good to merge. Let me know if you want a hand with any of the above, I'm happy to help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
