amaannawab923 opened a new pull request, #42115: URL: https://github.com/apache/superset/pull/42115
### SUMMARY The **Show summary** totals row is invisible on the AG Grid "Interactive Table" (Table v2) after the ag-grid 36 upgrade (#41882). **Root cause:** the pinned bottom row is built and populated correctly — the DOM contains the row with the correct aggregated values — but ag-grid 36 leaves its row-entrance animation class `ag-opacity-zero` (`opacity: 0`) permanently applied to the **pinned** bottom row. Normally ag-grid removes that class on the next animation frame to fade the row in; under v36 it is never removed for pinned rows, so the summary row renders fully but stays transparent. The entire data pipeline (`buildQuery` totals query → `transformProps` totals → the render gate) is correct; the failure is purely in ag-grid 36's render layer. The fix forces pinned rows opaque in the chart's styled container, overriding the stuck animation class. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **Before:** toggling "Show summary" shows no totals row (aggregate mode, with or without server pagination). **After:** the totals row (e.g. `Summary … 28.4k`) is visible, pinned at the bottom. ### TESTING INSTRUCTIONS 1. Enable the `AG_GRID_TABLE_ENABLED` feature flag. 2. Create an AG Grid "Interactive Table" in aggregate mode with at least one metric. 3. Toggle **Show summary** on. 4. The totals/summary row should appear pinned at the bottom (verified both with and without server pagination). ### ADDITIONAL INFORMATION Verified against a local build on apache `master` with `ag-grid-community` **36.0.0**: the pinned row's computed `opacity` was `0` (from `.ag-opacity-zero`); forcing pinned rows opaque restores visibility while keeping the entrance animation on regular data rows. **Related issue found during this investigation (not fixed in this PR):** custom conditional-formatting rules using the **Green (increase) / Red (decrease)** color scheme on a **time-comparison** table do not render. `transformProps` builds `basicColorColumnFormatters` but nothing in the AG Grid renderer consumes it (the classic `plugin-chart-table` does consume it via `basicColorColumnFormatters[row.index][column.key]`). Other conditional-formatting schemes (alert/gradient/error/success) work because they flow through `columnColorFormatters`, which is consumed. This green/red path will be addressed separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
