amaannawab923 commented on PR #42115: URL: https://github.com/apache/superset/pull/42115#issuecomment-5000538352
Added tests in 3bd8c7b: - `getCellStyle`: preserves a standard conditional-format background when the column has no increase/decrease formatter (the regression the review caught), applies the basic background when the column does have one, and skips the pinned summary row. - `transformProps`: Green/Red color-scheme rules are excluded from `columnColorFormatters` (the `'GreenFF'` guard) while standard rules are kept. 11 tests green locally across `getCellStyle.test.ts` and `transformProps.test.ts`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
