rusackas commented on PR #38657:
URL: https://github.com/apache/superset/pull/38657#issuecomment-4997267448
Thanks for the PR, Manoj! CI's failing right now, looks like the new test in
transformProps.test.ts is missing its closing brace before the
describe('Tooltip with long labels'...) block, so the file can't even parse,
that's what's tripping up pre-commit, lint, and one of the jest shards.
There's also a bot thread still open pointing out that Math.max(zoomBottom,
height * 0.08) only starts changing anything once the chart's taller than a few
hundred px, so the small panels this is meant to fix (the #37286 case) might
still get the old fixed offset. Worth confirming that's not the case before
this goes in.
Mind fixing the syntax break and settling that logic question? Happy to take
another look once CI's green. Holler if I can help more here, and push a commit
or whatever :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
