codeant-ai-for-open-source[bot] commented on code in PR #38657:
URL: https://github.com/apache/superset/pull/38657#discussion_r3601134174
##########
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts:
##########
@@ -1741,6 +1741,36 @@ test('should assign distinct dash patterns for multiple
time offsets consistentl
expect(symbol1).not.toEqual(symbol2);
});
+test('should adjust dataZoom bottom when chart height changes', () => {
+ const smallChart = createTestChartProps({
+ height: 300,
+ formData: { zoomable: true },
+ });
+ const largeChart = createTestChartProps({
+ height: 600,
+ formData: { zoomable: true },
+ });
+
+ const smallResult = transformProps(smallChart);
+ const largeResult = transformProps(largeChart);
+
+ const smallDataZoom = smallResult.echartOptions.dataZoom as any[];
+ const largeDataZoom = largeResult.echartOptions.dataZoom as any[];
Review Comment:
**Suggestion:** Replace this `any[]` cast with a concrete typed shape for
`dataZoom` entries to preserve static type checking. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This is a direct `any[]` cast in changed TypeScript code, which violates the
no-any-types rule.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 16)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=9e90091d8925489f94852523c854131d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=9e90091d8925489f94852523c854131d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts
**Line:** 1758:1758
**Comment:**
*Custom Rule: Replace this `any[]` cast with a concrete typed shape for
`dataZoom` entries to preserve static type checking.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38657&comment_hash=766e18b74b6fe19f452c918139929f42728b22bd8cdf5199f2df76631c9d507c&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38657&comment_hash=766e18b74b6fe19f452c918139929f42728b22bd8cdf5199f2df76631c9d507c&reaction=dislike'>๐</a>
##########
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts:
##########
@@ -1741,6 +1741,36 @@ test('should assign distinct dash patterns for multiple
time offsets consistentl
expect(symbol1).not.toEqual(symbol2);
});
+test('should adjust dataZoom bottom when chart height changes', () => {
+ const smallChart = createTestChartProps({
+ height: 300,
+ formData: { zoomable: true },
+ });
+ const largeChart = createTestChartProps({
+ height: 600,
+ formData: { zoomable: true },
+ });
+
+ const smallResult = transformProps(smallChart);
+ const largeResult = transformProps(largeChart);
+
+ const smallDataZoom = smallResult.echartOptions.dataZoom as any[];
Review Comment:
**Suggestion:** Replace this `any[]` cast with a concrete typed shape for
`dataZoom` entries so the test remains type-safe. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The rule forbids new or changed TypeScript code that uses `any`. This line
directly casts to `any[]`, so the violation is real and matches the rule.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 16)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5b74432b3eed4fdc8a67b9e3b7a1fc3c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5b74432b3eed4fdc8a67b9e3b7a1fc3c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts
**Line:** 1757:1757
**Comment:**
*Custom Rule: Replace this `any[]` cast with a concrete typed shape for
`dataZoom` entries so the test remains type-safe.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38657&comment_hash=138defed174e182be109c667fb396ee1da7c38f0d87564e0c6004700101505eb&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38657&comment_hash=138defed174e182be109c667fb396ee1da7c38f0d87564e0c6004700101505eb&reaction=dislike'>๐</a>
##########
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts:
##########
@@ -1837,3 +1867,26 @@ describe('Tooltip with long labels', () => {
expect(result).toContain('599616000000');
});
});
+
+test('should adjust dataZoom bottom when chart height changes', () => {
+ const smallChart = createTestChartProps({
+ height: 300,
+ formData: { zoomable: true },
+ });
+ const largeChart = createTestChartProps({
+ height: 600,
+ formData: { zoomable: true },
+ });
+
+ const smallResult = transformProps(smallChart);
+ const largeResult = transformProps(largeChart);
+
+ const smallBottom = (smallResult.echartOptions.dataZoom as any[])[0].bottom;
Review Comment:
**Suggestion:** Replace the inline `any[]` assertion with a concrete type
before indexing into `dataZoom`. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The changed line uses `any[]` explicitly, so it is a real TypeScript `any`
usage covered by the rule.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 16)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b27333f670e349a383a85e00ba43f2d4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b27333f670e349a383a85e00ba43f2d4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts
**Line:** 1884:1884
**Comment:**
*Custom Rule: Replace the inline `any[]` assertion with a concrete type
before indexing into `dataZoom`.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38657&comment_hash=69bb24392b186b96e53f476cab92ffa9f8e31c49b971be266f2312636bf4905d&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38657&comment_hash=69bb24392b186b96e53f476cab92ffa9f8e31c49b971be266f2312636bf4905d&reaction=dislike'>๐</a>
##########
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts:
##########
@@ -1837,3 +1867,26 @@ describe('Tooltip with long labels', () => {
expect(result).toContain('599616000000');
});
});
+
+test('should adjust dataZoom bottom when chart height changes', () => {
+ const smallChart = createTestChartProps({
+ height: 300,
+ formData: { zoomable: true },
+ });
+ const largeChart = createTestChartProps({
+ height: 600,
+ formData: { zoomable: true },
+ });
+
+ const smallResult = transformProps(smallChart);
+ const largeResult = transformProps(largeChart);
+
+ const smallBottom = (smallResult.echartOptions.dataZoom as any[])[0].bottom;
+ const largeBottom = (largeResult.echartOptions.dataZoom as any[])[0].bottom;
Review Comment:
**Suggestion:** Replace the inline `any[]` assertion with an explicit typed
array element definition for `dataZoom` entries. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This line contains an inline `as any[]` assertion in new TypeScript code,
which directly violates the no-any-types rule.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 16)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=50a375bdd3954e3a957ca843e151923a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=50a375bdd3954e3a957ca843e151923a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts
**Line:** 1885:1885
**Comment:**
*Custom Rule: Replace the inline `any[]` assertion with an explicit
typed array element definition for `dataZoom` entries.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38657&comment_hash=1dbf6ea3d1d44f6c5ed07cb4d8dd082c7d3d64f6bab98ea764dfefc2f098bb22&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38657&comment_hash=1dbf6ea3d1d44f6c5ed07cb4d8dd082c7d3d64f6bab98ea764dfefc2f098bb22&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
