rusackas commented on PR #40907: URL: https://github.com/apache/superset/pull/40907#issuecomment-4997299993
Hey Vitalii, thanks for the thorough writeup here. Pre-commit's failing right now though due to mypy errors in the new drill-detail tests, plus prettier and ruff-format both failing. That needs to pass before anything else. There's also a decent pile of unresolved review-bot comments here that look worth assessing. The one about `hasPostProcessing` starting `false` during the async detection window seems legit. A header click in that window could fire a server-side orderby on a post-processed query before we know it shouldn't. The one about clearing a sort dropping `orderby` entirely and falling back to the metric default (while the header shows no sort) sounds valid too. Can you knock out the pre-commit failures and take a pass at those two? Then I'll be happy to take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
