rusackas commented on PR #40907: URL: https://github.com/apache/superset/pull/40907#issuecomment-5040351010
This is a solid, well-tested feature, thanks! Before I merge, worth aligning validation across endpoints: `data()` checks orderby direction before `_create_query_context_from_form()`, but `get_data()`/`data_from_cache()` still rely solely on marshmallow, so the same bad input produces different error shapes depending on entry point. Holler if you want help at all to get it across the finish line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
