rusackas commented on PR #33924: URL: https://github.com/apache/superset/pull/33924#issuecomment-4999000676
Circling back on the cache-key thread here. I put up #42122 with tests proving the `current_user_*` family is collision-safe even though it skips the cache key when a value is absent. Absent renders are identical for every user (the macro just returns `None`), so they share a cache entry correctly rather than colliding, and present values are always distinct in the key. That's the same pattern `get_guest_user_attribute` uses here, so I think we're good on that front. @Yash2412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
