bito-code-review[bot] commented on code in PR #33924:
URL: https://github.com/apache/superset/pull/33924#discussion_r3607514392
##########
tests/integration_tests/security/api_tests.py:
##########
@@ -195,6 +195,174 @@ def test_post_guest_token_authorized(self):
assert user == decoded_token["user"]
assert resource == decoded_token["resources"][0]
+ @pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
+ def test_post_guest_token_with_attributes(self) -> None:
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incomplete type annotation consistency</b></div>
<div id="fix">
Adding `-> None` to test methods is correct per project type-hint standards
(AGENTS.md, BITO.md [7819]). However, rule [13290] requires applying type hints
consistently to all functions of the same kind in the file. 8+ other test
methods in this class lack annotations (e.g.,
`test_post_guest_token_authorized` at line 174). Applying the fix to all
methods maintains consistent code quality.
</div>
</div>
<small><i>Code Review Run #b858c4</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
