bito-code-review[bot] commented on PR #42127:
URL: https://github.com/apache/superset/pull/42127#issuecomment-4999547286
<!-- Bito Reply -->
The suggestion to add explicit type annotations to the local metadata
structures in the test is correct and aligns with standard Python type-hinting
practices. You can resolve this by explicitly typing the
`placeholder_description` and `result_description` variables as
`list[tuple[str, str, None, None, None, None, None]]`.
Here is the corrected code snippet:
```python
placeholder_description: list[tuple[str, str, None, None, None, None,
None]] = [
("Result", "STRING", None, None, None, None, None),
]
result_description: list[tuple[str, str, None, None, None, None, None]]
= [
("value", "BIGINT", None, None, None, None, None),
]
```
I have checked the PR and there are no other comments in the review
discussion. Would you like me to review the rest of the PR for similar
type-hinting improvements?
**tests/unit_tests/models/core_test.py**
```
placeholder_description: list[tuple[str, str, None, None, None, None, None]]
= [
("Result", "STRING", None, None, None, None, None),
]
result_description: list[tuple[str, str, None, None, None, None, None]]
= [
("value", "BIGINT", None, None, None, None, None),
]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
