codeant-ai-for-open-source[bot] commented on code in PR #42127:
URL: https://github.com/apache/superset/pull/42127#discussion_r3600733164
##########
tests/unit_tests/models/core_test.py:
##########
@@ -1815,6 +1815,50 @@ def
test_execute_sql_preserves_line_comments_single_statement(
assert "/*" not in executed_sql
+def test_get_df_captures_description_after_fetch(mocker: MockerFixture) ->
None:
+ """Fetch asynchronous results before capturing their final column metadata.
+
+ Some asynchronous DB-API drivers (e.g. Spark Thrift) expose placeholder
+ ``cursor.description`` until a fetch call waits for the operation to
finish.
+ Capturing ``description`` after ``fetch_data`` ensures the real column
+ metadata is used.
+ """
+ database = Database(database_name="my_db", sqlalchemy_uri="sqlite://")
+
+ cursor = mocker.MagicMock()
+ placeholder_description = [
+ ("Result", "STRING", None, None, None, None, None),
+ ]
+ result_description = [
+ ("value", "BIGINT", None, None, None, None, None),
+ ]
Review Comment:
**Suggestion:** Add explicit type annotations for the newly introduced local
metadata structures so the test fully complies with the type-hinting rule for
relevant variables. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The new local variables are simple list literals assigned in Python code and
can be explicitly annotated. The custom rule requires type hints on new or
modified Python code for relevant variables that can be annotated, so this
omission is a real violation.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b92932a2488f4c0c96404abeb26ed130&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b92932a2488f4c0c96404abeb26ed130&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/models/core_test.py
**Line:** 1829:1834
**Comment:**
*Custom Rule: Add explicit type annotations for the newly introduced
local metadata structures so the test fully complies with the type-hinting rule
for relevant variables.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42127&comment_hash=a4e590b563a713460e04a56787ce76fae100853e53b0170520721cefed0b2f73&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42127&comment_hash=a4e590b563a713460e04a56787ce76fae100853e53b0170520721cefed0b2f73&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
