aminghadersohi commented on code in PR #40472:
URL: https://github.com/apache/superset/pull/40472#discussion_r3600939380
##########
superset-frontend/src/pages/ChartCreation/index.tsx:
##########
@@ -341,6 +341,7 @@ export const ChartCreation = ({
optionFilterProps={['id', 'table_name']}
placeholder={t('Choose a %s', datasetLabelLower())}
showSearch
+ oneLine
Review Comment:
`oneLine` doesn't actually reach the truncation this is meant to fix. The
selected value's width is capped by `.dataset > div { width: 300px }` a few
lines up (line 92-93 in this file), and `oneLine`'s effect (`maxTagCount` /
`popupMatchSelectWidth` in `Select.tsx`) is scoped to multi-select tag
rendering. On a single-select like this one it mostly just changes the dropdown
popup's width, not the truncation of a long dataset name shown in the closed
field. To actually fix the #40430-style truncation here, widening/removing that
fixed 300px (or adding a tooltip on overflow) would get closer to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
