rusackas commented on PR #40472: URL: https://github.com/apache/superset/pull/40472#issuecomment-5005914466
Thanks for sticking with this one. @sadpandajoe's point about the hardcoded minWidth not scaling to longer permission names is still open, and I don't *think* it's been addressed yet. @aminghadersohi's newest note is that `oneLine` on the ChartCreation select doesn't actually reach the truncation either. The cap there is the fixed 300px `.dataset` width a few lines up. That one's also outside #40430's scope, might be worth splitting into its own PR, but I'm not going to be to picky there. We've got merge conflicts with master too, so this needs a rebase regardless. Holler if I can help with any of the above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
