rusackas commented on PR #39469: URL: https://github.com/apache/superset/pull/39469#issuecomment-5005905914
Thanks for sticking with this one, @shantanukhond. CI's failing now, as you probably noticed. That includes the ruff-format nit on `auth_session_stamp.py`. `test_user_gets_all_charts` and `test_user_gets_all_datasets` are failing 401 instead of 200 on every DB backend, which looks like it's due to the session-stamp changes breaking logins more broadly than just the password flow. The login-timing side-channel between real and nonexistent users keeps getting flagged in reviews, and the lockout/rate-limit keys in `AUTH_DB_CONFIG` are documented but not wired into the login path. The session-stamp fail-open question I left open for @dpgaspar last pass is still unanswered too, if you can tend to that. Need CI green and those closed out before this is mergeable. Happy to jump in if I can help resolve bot comments or any of the above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
