rusackas commented on PR #42137: URL: https://github.com/apache/superset/pull/42137#issuecomment-5006890097
Thanks for this @J0s3-H3nr1qu3 I don't speak Portuguese (either version!), but Codex suggested these changes: > [messages.po#L15587](https://github.com/apache/superset/blob/39baea1c731b559a4f0795792223da83b79298fe/superset/translations/pt/LC_MESSAGES/messages.po#L15587) / [L15669](https://github.com/apache/superset/blob/39baea1c731b559a4f0795792223da83b79298fe/superset/translations/pt/LC_MESSAGES/messages.po#L15669): Save / Saved are still Salvar. For pt_PT this should be Guardar; Saved should be Guardado/Guardada depending on context. Saved = Salvar is also grammatically wrong state vs action. > [messages.po#L20054](https://github.com/apache/superset/blob/39baea1c731b559a4f0795792223da83b79298fe/superset/translations/pt/LC_MESSAGES/messages.po#L20054): still very Brazilian/inconsistent: botão salvar, exibição do painel, usuários avançados. I’d expect something like botão Guardar, vista do dashboard, utilizadores avançados. > [messages.po#L1258](https://github.com/apache/superset/blob/39baea1c731b559a4f0795792223da83b79298fe/superset/translations/pt/LC_MESSAGES/messages.po#L1258), [L7939](https://github.com/apache/superset/blob/39baea1c731b559a4f0795792223da83b79298fe/superset/translations/pt/LC_MESSAGES/messages.po#L7939), [L22212](https://github.com/apache/superset/blob/39baea1c731b559a4f0795792223da83b79298fe/superset/translations/pt/LC_MESSAGES/messages.po#L22212): subjects as sujeitos reads unnatural in UI/admin Portuguese. I’d use entidades, utilizadores/grupos, or rephrase depending on what Superset means there. > [messages.po#L24617](https://github.com/apache/superset/blob/39baea1c731b559a4f0795792223da83b79298fe/superset/translations/pt/LC_MESSAGES/messages.po#L24617) and [L24629](https://github.com/apache/superset/blob/39baea1c731b559a4f0795792223da83b79298fe/superset/translations/pt/LC_MESSAGES/messages.po#L24629): Deleting ... will break those objects became irá danificar esses objetos. That sounds physical/odd. Better: fará com que esses objetos deixem de funcionar or irá afetar esses objetos. > There are a few leftover pt_BR terms not changed by the PR, like banco de dados, buscar, Excluir, and usuários. Since the PR claims a full hand review, I’d ask the author to sweep those too. Let me know if you concur, before we merge :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
