J0s3-H3nr1qu3 commented on PR #42137: URL: https://github.com/apache/superset/pull/42137#issuecomment-5021305949
Thanks for the review, @rusackas — the catches were all real. I agree with all four points: - `Save`/`Saved`: fixed to `Guardar`/`Guardado` (`Salvar` is pt_BR) - L20054: fixed `botão salvar` → `botão Guardar`, `exibição do painel` → `vista do dashboard`, `usuários avançados` → `utilizadores avançados` - `subjects` → `entidades` instead of `sujeitos` (applied everywhere it appears) - "will break those objects" → `fará com que esses objetos deixem de funcionar` instead of `irá danificar` (danificar reads as physical damage) I also did a full sweep for other pt_BR leftovers beyond what was flagged and found a few more: `banco de dados` → `base de dados`, `buscar` → `obter`, and `Excluir`/`Excluído` → `Eliminar`/`Eliminado` (only where used for delete — `excluir` is correct pt_PT when it means exclude/filter, so I left those alone). Also rebased onto current master and resolved the conflicts — should be clean now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
