rusackas commented on PR #41976: URL: https://github.com/apache/superset/pull/41976#issuecomment-5009028570
Thanks @RehanIslam09! The sorting concern from @gabotorresruiz and codeant seems addressed on the latest push. The sorter reads `props.value` directly for `ValueCell` cells now, with the Sparkline path intact, so those threads can be resolved. One small thing: the JSDoc on `ValueCell` and the comment block in `sortUtils.ts` still describe the old prop shape, mind updating those? There are a few other bot comments to assess/address/resolve too, if you don't mind, then I'll be happy to approve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
