bito-code-review[bot] commented on code in PR #34794:
URL: https://github.com/apache/superset/pull/34794#discussion_r3607452789
##########
superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts:
##########
@@ -425,8 +433,17 @@ export default function transformProps(
const array = ensureIsArray(chartProps.rawFormData?.time_compare);
const inverted = invert(verboseMap);
+ let patternIncrement = 0;
rawSeriesA.forEach(entry => {
+ const derivedSeries = isDerivedSeries(entry, chartProps.rawFormData);
+ const lineStyle: LineStyleOption = {};
+ if (derivedSeries) {
+ patternIncrement += 1;
+ // use a combination of dash and dot for the line style
+ lineStyle.type = [(patternIncrement % 5) + 1, (patternIncrement % 3) +
1];
+ lineStyle.opacity = OpacityEnum.DerivedSeries;
+ }
Review Comment:
<!-- Bito Reply -->
It is positive that you have added tests to cover the derived-series dash
pattern, as this directly addresses the concern raised by the reviewer
regarding missing test coverage for the new functionality. Ensuring that both
the expected behavior and the no-op case are verified helps prevent future
regressions and improves the robustness of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
