rusackas commented on code in PR #34794:
URL: https://github.com/apache/superset/pull/34794#discussion_r3607932214
##########
superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts:
##########
@@ -425,8 +433,17 @@ export default function transformProps(
const array = ensureIsArray(chartProps.rawFormData?.time_compare);
const inverted = invert(verboseMap);
+ let patternIncrement = 0;
Review Comment:
Good catch, keyed the pattern to the time offset now instead of a raw
per-series counter, so series sharing an offset get the same dash pattern
across both queries.
##########
superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts:
##########
@@ -425,8 +433,17 @@ export default function transformProps(
const array = ensureIsArray(chartProps.rawFormData?.time_compare);
const inverted = invert(verboseMap);
+ let patternIncrement = 0;
rawSeriesA.forEach(entry => {
+ const derivedSeries = isDerivedSeries(entry, chartProps.rawFormData);
Review Comment:
Good catch, passing the resolved series name into isDerivedSeries now so
exact offset-only names get picked up, same as the regular Timeseries transform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
