rusackas commented on PR #41527: URL: https://github.com/apache/superset/pull/41527#issuecomment-5013095045
Thanks for tackling this! It's showing as conflicting with master right now and pre-commit is failing in CI, so it'll need a rebase before this can move forward. Separately, the diff adds a whole 'Other' custom range picker (number input + unit select) in `CommonFrame.tsx` that isn't mentioned anywhere in the description, only the four new presets are. Was that intentional, or did it get bundled in by accident? If intentional it's probably worth splitting into its own PR, it's a fair bit more surface area than the stated scope. Or revising the PR description explaning what's going on there could be OK too. Let me know if you want help with the rebase or any of the above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
