rusackas commented on PR #33924: URL: https://github.com/apache/superset/pull/33924#issuecomment-5018534130
Thanks for the fixes, Yash. As sadpandajoe flagged, there's one more thing to contend with. `get_guest_user_attribute()` escaping list elements before `where_in` escapes them again, which could silently drop matches for values with a quote in them. Can you take a look? Also `pre-commit`'s failing on mypy errors in `security_tests.py` against the `GuestTokenUser` type, that'll need fixing too before this is mergeable. Holler if I can help with any of that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
