villebro commented on PR #39171: URL: https://github.com/apache/superset/pull/39171#issuecomment-5024474411
> Nice work here, Michael, LGTM! > > One thing I'm curious about, though. `ExtensionStorageDAO.set` does a select-then-insert/update rather than an atomic upsert, and the unique constraint on `extension_storage` seeminly won't catch two concurrent writes to the same shared key since `user_fk` is NULL there. Is this a race condition we care about, or edge case we can live with? That's a good point. I think we should use the distributed lock for this as we do in other similar cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
