rusackas commented on code in PR #41127: URL: https://github.com/apache/superset/pull/41127#discussion_r3615899352
########## superset/config.py: ########## @@ -2005,6 +2005,9 @@ def SQL_QUERY_MUTATOR( # pylint: disable=invalid-name,unused-argument # noqa: # An example use case is if data has role based access controls, and you want to apply # a SET ROLE statement alongside every user query. Changing this variable maintains # functionality for both the SQL_Lab and Charts. +# This applies consistently in SQL Lab: with MUTATE_AFTER_SPLIT = True the mutator runs +# on each individual statement, and with MUTATE_AFTER_SPLIT = False it runs once on the +# un-split query block. Review Comment: Fair catch against the head you reviewed... a botched force-push had dropped the per-statement mutation for those engines. It's back at head, so the comment matches the behavior again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
