rusackas commented on PR #39469: URL: https://github.com/apache/superset/pull/39469#issuecomment-5025540910
@dpgaspar this is the one design call I'd really like your eyes on before this lands, since it touches core auth semantics. The session-stamp check (`superset/utils/auth_session_stamp.py`, `validate_session_auth_stamp_for_request`) fails open in two cases. A logged-in user with no stamp row in the DB is allowed through, since rows are only created at login and this covers sessions that predate the upgrade. And a session cookie carrying no stamp adopts the current DB value when the session is flask-login fresh. Remember-cookie sessions without a stamp are invalidated. The residual gap: a signed pre-upgrade cookie keeps its fresh flag, so if one had been exfiltrated it would adopt the new stamp and survive the first password change after the upgrade, one time. Is that an acceptable rollout tradeoff to keep from mass-logging-out every session on upgrade, or would you rather we fail closed and force a one-time re-login for everyone? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
