codeant-ai-for-open-source[bot] commented on code in PR #39469:
URL: https://github.com/apache/superset/pull/39469#discussion_r3616482057
##########
superset/cli/reset.py:
##########
@@ -68,7 +69,11 @@ def factory_reset(
# Validate the user
password = click.prompt("Admin Password", hide_input=True)
user = security_manager.find_user(username)
- if not user or not check_password_hash(user.password, password):
+ if (
+ not user
+ or not user.is_active
+ or not verify_auth_db_password(user.password, password)
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag authentication-failure bookkeeping or lockout/rate-limit
bypasses in CLI commands that run with host shell access inside the operator
trust boundary; those commands can already access the metadata DB directly.
**Applied to:**
- `superset/cli/**`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
