rusackas commented on PR #41803: URL: https://github.com/apache/superset/pull/41803#issuecomment-5028841181
Ugh. Something's off with things here. The replies to codeant's comments claim `set[str]`/`tuple[str, str]`/`int` annotations got added to `trino.py`, and that the `IF (...)` block-vs-scalar-call ambiguity got fixed with a matching test. Checked the head commit and none of that's actually there: `BLOCK_OPENERS`, `AMBIGUOUS_OPENERS`, `BODY_KEYWORDS`, `routine_mode`, `depth`, and `paren_depth` are still bare, and `_block_depth_delta`/`_consume_block` still just check whether the next token is `(`. The PR body's own "Known limitation" section confirms `IF (a > b) THEN` still fails, so the "fixed" replies are just wrong, not a matter of taste. Separately, `Parser._parse` is copied wholesale from sqlglot internals rather than extended through the public `FUNCTIONS`/`TRANSFORMS` hooks the other dialects (Dremio, Firebolt) use, so it'll silently drift on the next sqlglot bump. Worth a comment pinning the sqlglot version this was copied from, at least. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
