rusackas commented on PR #41803: URL: https://github.com/apache/superset/pull/41803#issuecomment-5040211633
One thing I learned while upstreaming this: per Trino's actual grammar (`rootQuery` in SqlBase.g4), inline functions get their own leading `WITH` clause and can't be comma-mixed with named queries. So the `WITH cte AS (SELECT 1), FUNCTION ...` case this PR supports (and pins with a test) isn't valid Trino... tobymao/sqlglot#7926 emits `WITH <functions> WITH <ctes>` instead. Being permissive on input doesn't hurt anything here, but worth knowing if anyone compares the two implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
