codeant-ai-for-open-source[bot] commented on code in PR #42266:
URL: https://github.com/apache/superset/pull/42266#discussion_r3620567803
##########
superset-frontend/src/filters/components/common.ts:
##########
@@ -25,6 +25,22 @@ export const RESPONSIVE_WIDTH = 0;
export const FilterPluginStyle = styled.div<PluginFilterStylesProps>`
min-height: ${({ height }) => height}px;
width: ${({ width }) => (width === RESPONSIVE_WIDTH ? '100%' :
`${width}px`)};
+ /* Input / InputNumber filter value controls resolve text-align by */
+ /* inheritance, so pin them to the inline start to keep the caret and typed
*/
+ /* text at the left edge. */
Review Comment:
**Suggestion:** The new comment says text is kept at the “left edge,” but
the implemented rule uses `text-align: start`, which maps to the right edge in
RTL; update the comment to describe “inline start” instead to avoid misleading
future changes and tests. [comment mismatch]
<details>
<summary><b>Severity Level:</b> Minor 🧹</summary>
```mdx
- ⚠️ Comment misleading about RTL alignment of filter inputs.
- ⚠️ No runtime behavior affected; UI works as intended.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Open `superset-frontend/src/filters/components/common.ts` and locate
`FilterPluginStyle` definition at lines 25-44 in the PR diff.
2. Observe the comments at lines 28-30: they mention "inline start" (correct
for
`text-align: start`) but also say "text at the left edge."
3. Note the implementation at line 31: `text-align: start;` which, per CSS
spec, aligns
text to the right edge in RTL contexts.
4. In an RTL dashboard (where inline start is right), native filter value
inputs render
caret/text at the right edge, while the comment still describes "left edge",
so the
comment is mildly misleading but behavior is correct.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=d5ccc26ff7f745d6b273ec1d2df71d25&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=d5ccc26ff7f745d6b273ec1d2df71d25&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/filters/components/common.ts
**Line:** 28:30
**Comment:**
*Comment Mismatch: The new comment says text is kept at the “left
edge,” but the implemented rule uses `text-align: start`, which maps to the
right edge in RTL; update the comment to describe “inline start” instead to
avoid misleading future changes and tests.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42266&comment_hash=ed89e4a4a2ab359343c1a20e64b985846dee3b4f92d7e7e573827ec23ce0e009&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42266&comment_hash=ed89e4a4a2ab359343c1a20e64b985846dee3b4f92d7e7e573827ec23ce0e009&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
