sadpandajoe commented on code in PR #42266:
URL: https://github.com/apache/superset/pull/42266#discussion_r3626493945
##########
superset-frontend/src/filters/components/common.ts:
##########
@@ -25,6 +25,22 @@ export const RESPONSIVE_WIDTH = 0;
export const FilterPluginStyle = styled.div<PluginFilterStylesProps>`
min-height: ${({ height }) => height}px;
width: ${({ width }) => (width === RESPONSIVE_WIDTH ? '100%' :
`${width}px`)};
+ /* Input / InputNumber filter value controls resolve text-align by */
+ /* inheritance, so pin them to the inline start to keep the caret and typed
*/
+ /* text at the left edge. */
+ text-align: start;
Review Comment:
Can we add a focused Jest regression test for this fix? Rendering
`FilterPluginStyle` and asserting each retained `text-align: start` rule with
`toHaveStyleRule` would protect the corrective CSS; the existing DOM-contract
test only protects the Ant Design class hook.
##########
superset-frontend/src/filters/components/common.ts:
##########
@@ -25,6 +25,22 @@ export const RESPONSIVE_WIDTH = 0;
export const FilterPluginStyle = styled.div<PluginFilterStylesProps>`
min-height: ${({ height }) => height}px;
width: ${({ width }) => (width === RESPONSIVE_WIDTH ? '100%' :
`${width}px`)};
+ /* Input / InputNumber filter value controls resolve text-align by */
+ /* inheritance, so pin them to the inline start to keep the caret and typed
*/
+ /* text at the left edge. */
+ text-align: start;
+
+ /* antd v6 sets 'text-align: center' directly on '.ant-select-content' for */
Review Comment:
The locked Ant Design 6.5.1 CSS does not set `text-align: center` on
`.ant-select-multiple .ant-select-content`; that rule only sets wrapping, item
alignment, and line height. Can we keep the wrapper-level rule, remove this
nested selector, and document the actual inherited source instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
