rusackas commented on PR #40967: URL: https://github.com/apache/superset/pull/40967#issuecomment-5036236240
@kgabryje good catch on the time-comparison leak. The offset series keep the raw metric label with the `__<offset>` suffix while the classification only knew the verbose base label, so the size metric's offset copies slipped through. Fixed by matching both forms and keying the size lookups by offset, so each comparison series is sized from its own offset's values. The new regression test reproduces the leak on the old code and passes now. On the advisory notes, I'd rather tackle the Bar/Scatter control-factory dedup as a follow-up so this one stays reviewable, and I'll fold the test-helper casting cleanup into that pass. CI's running 🤞 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
